Merged
Conversation
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
wcoenraads
requested changes
Feb 10, 2025
Collaborator
wcoenraads
left a comment
wcoenraads
left a comment
There was a problem hiding this comment.
This looks good to me! The only thing left to do is to add an OMBC definition to s2_control_type.py.
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
wcoenraads
approved these changes
Mar 4, 2025
Collaborator
wcoenraads
left a comment
wcoenraads
left a comment
There was a problem hiding this comment.
This looks good - thanks!
Collaborator
|
@VladIftime Could you resolve the conflicts and merge (or request a re-review) soon? I fear otherwise the merge conflicts might grow out of hand. |
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.